fix: remove postinstall chmod that breaks Windows npm install - #612
Closed
chrille0313 wants to merge 1 commit into
Closed
fix: remove postinstall chmod that breaks Windows npm install#612chrille0313 wants to merge 1 commit into
chrille0313 wants to merge 1 commit into
Conversation
npm automatically sets the executable bit on files declared in the `bin` field when installing a package, making the `chmod +x` in postinstall redundant. The script also broke on Windows since `chmod` and `true` are not available in cmd.exe. Closes pgflow-dev#610
|
jumski
added a commit
that referenced
this pull request
Sep 4, 2026
## Summary - The `pgflow` package's `postinstall` ran `chmod +x dist/index.js || true`. `chmod` and `true` do not exist in Windows cmd.exe, so `npm install pgflow` and `npx pgflow@latest install` failed with `'chmod' is not recognized as an internal or external command`. - npm sets the executable bit on files declared in the `bin` field during install, so the script was redundant even on Unix. Removal is the whole fix. - Adds a permanent `windows-latest` smoke workflow as the regression test: build the CLI, `pnpm pack`, install the tarball into a clean directory with lifecycle scripts enabled, run the npm-created `pgflow.cmd --version` shim. The rest of CI runs on Ubuntu and invokes `node dist/index.js` directly, so npm installation and Windows shims were never exercised. - One `pgflow` patch changeset for the 0.15.1 release group (#666). - Recreates the minimal removal from #612 against current `main` (#612 was based on v0.13.3). ## Checks - `pnpm nx build cli` — pass - `pnpm pack` in `pkgs/cli` — tarball contains `dist/`, no `postinstall` in its `package.json` - CLI unit tests — 43/43 pass - `prettier --check` on all three touched files — pass - Windows smoke job runs in this PR's CI Closes #610
Contributor
|
closed by #669 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm automatically sets the executable bit on files declared in the
binfield when installing a package, making thechmod +xin postinstall redundant. The script also broke on Windows sincechmodandtrueare not available in cmd.exe.Closes #610